Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue that caused the TunnelVision-fix not to be publicly available #3889

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix an issue that caused the TunnelVision-fix not to be publicly available #3889

merged 1 commit into from
Jan 28, 2025

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jan 28, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1207603085593419/1209262365365751/f

Description

Our TunnelVision exploit fix was not released publicly due to a mistake that's being addressed here.

Testing

  1. Connect to a network with TunnelVision enabled.
  2. Run our app and make sure you're not an internal user.
  3. Start the VPN
  4. Check that TunnelVision is guarded against.
  5. Check with another VPN that it fails to address TunnelVision.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@diegoreymendez diegoreymendez self-assigned this Jan 28, 2025
@diegoreymendez diegoreymendez changed the base branch from main to release/ios/7.155.0 January 28, 2025 16:06
not-a-rootkit
not-a-rootkit approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@not-a-rootkit not-a-rootkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@diegoreymendez diegoreymendez merged commit 2baa4e6 into release/ios/7.155.0 Jan 28, 2025
30 of 31 checks passed
@diegoreymendez diegoreymendez deleted the diego/make-enforce-routes-public branch January 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-a-rootkit not-a-rootkit not-a-rootkit approved these changes

Assignees

@diegoreymendez diegoreymendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegoreymendez @not-a-rootkit