Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release automation fixes #3886

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

kshann
Copy link
Contributor

@kshann kshann commented Jan 28, 2025

Task/Issue URL: https://app.asana.com/0/414709148257752/1209252157507552/f
Tech Design URL:
CC:

Description:
This will do the following:

  • Root.plist manually updated to the correct version
  • Root.plist automatically being updated instead of being $(MARKETING_VERSION) as part of release flow
  • Skipping release builds when pr checks run from release flow
  • Bump plugin (which contains `Root.plist PListBuddy update logic

Steps to test this PR:

  1. After merging I will run a hotfix flow which should test the logic, Root.plist logic was tested in private automation test repo.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@kshann kshann requested a review from ayoy January 28, 2025 12:16
@kshann kshann merged commit c861845 into release/ios/7.155.0 Jan 28, 2025
18 checks passed
@kshann kshann deleted the kieran/release-automation-fixes branch January 28, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants