This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Make connection tester non-failable on VPN startup #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Jan 28, 2025
1 task
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 29, 2025
Task/Issue URL: https://app.asana.com/0/1207603085593419/1209248230850409/f iOS PR: duckduckgo/iOS#3885 macOS PR: duckduckgo/macos-browser#3791 What kind of version bump will this require?: Patch ## Description Make sure the Connection Tester isn't being used for rekeying anymore, so we can let it fail silently and not block VPN startup.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jan 29, 2025
Task/Issue URL: https://app.asana.com/0/1207603085593419/1209248230850409/f iOS PR: duckduckgo/iOS#3885 BSK PR: duckduckgo/BrowserServicesKit#1197 ## Description Make sure the Connection Tester isn't being used for rekeying anymore, so we can let it fail silently and not block VPN startup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1209248230850409/f
macOS PR: duckduckgo/macos-browser#3791
BSK PR: duckduckgo/BrowserServicesKit#1197
Description
Make sure the Connection Tester isn't being used for rekeying anymore, so we can let it fail silently and not block VPN startup.
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Internal references:
Software Engineering Expectations
Technical Design Template