Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show fetch favicons prompt when dismissing settings #3884

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jan 28, 2025

Task/Issue URL: https://app.asana.com/0/392891325557410/1209231808112963/f
Tech Design URL:
CC:

Description:
Adds a notification for settings did disappear and sets a flag when missing icons are detected.

Steps to test this PR:

  1. Clean slate app
  2. Go to new tab page
  3. Open settings and Sync with another device
  4. Swipe to close settings
  5. Should get prompted to update icons
  6. Repeat above steps but back out of settings using back button and done, should also get prompt
  7. Smoke test settings (e.g. change some appearance, access email, change the burn animation, etc)
  8. Then browse to a page, then create a new tab (tab switcher -> plus button). The prompt should not be shown, because it's already been seen.

Definition of Done (Internal Only):

@brindy brindy requested a review from ayoy January 28, 2025 01:24
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works great. Thanks @brindy!

DuckDuckGo/FavoritesViewModel.swift Outdated Show resolved Hide resolved
@brindy brindy merged commit 383e729 into main Jan 31, 2025
13 checks passed
@brindy brindy deleted the brindy/fix-icons-prompt branch January 31, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants