Authv2 / adding v2 classes #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo-iOS.xcodeproj/project.pbxproj # DuckDuckGo-iOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
miasma13
approved these changes
Jan 31, 2025
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 31, 2025
Task/Issue URL: https://app.asana.com/0/1205842942115003/1209170372758737/f iOS PR: duckduckgo/iOS#3882 macOS PR: duckduckgo/macos-browser#3789 What kind of version bump will this require?: Patch **Description**: - `Subscription` renamed `PrivacyProSubscription` - `APIService` renamed `SubscriptionAPIService` - Subscription V2 classes added but not used - If a struct or an enum has been removed (e.g `GetProductsItem`) that code is shared between V1 and V2 and has been moved in the V2 version of the class
# Conflicts: # DuckDuckGo-iOS.xcodeproj/project.pbxproj # DuckDuckGo-iOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1209170372758737/f
Description:
New BSK version with Subscription V2 alongside V1
Steps to test this PR:
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template