Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple bangs #3869

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Support multiple bangs #3869

merged 2 commits into from
Jan 24, 2025

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 24, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209237779934842/f

Description:
Add support for more bangs combinations

Steps to test this PR:

  1. Use this config file http://jsonblob.com/api/1332301684340350976
  2. Open the app and type !ai test, it should open the custom duck.ai
  3. Test the same with other bangs like aichat, and chat (duck.ai is not yet supported in the FE)

@Bunn Bunn marked this pull request as ready for review January 24, 2025 19:28
@Bunn Bunn requested a review from samsymons January 24, 2025 19:28
samsymons
samsymons approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bunn Bunn merged commit f5462cd into main Jan 24, 2025
19 checks passed
@Bunn Bunn deleted the bunn/aichat/new-bangs branch January 24, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @samsymons