Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AI Chat user script leak #3858

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Fix AI Chat user script leak #3858

merged 2 commits into from
Jan 24, 2025

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 23, 2025

Task/Issue URL: https://app.asana.com/0/1204167627774280/1209224418262161/f
Tech Design URL:
CC:

Description:
Fix AI Chat user script leak

Steps to test this PR:

  1. Set yourself as internal
  2. On profiler, mark a generation after opening the app
  3. Open AI Chat, close it, then mark another
  4. You shouldn’t see userscript addresses hanging around

Definition of Done (Internal Only):

@Bunn Bunn requested a review from brindy January 23, 2025 18:58
brindy
brindy approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to see the user scripts being cleaned up as expected and nothing hanging around. Thanks

@Bunn Bunn merged commit c0b80cd into main Jan 24, 2025
16 checks passed
@Bunn Bunn deleted the bunn/aichat/leak-script branch January 24, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @brindy