-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to autofill DAU reporting for credential provider extension #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-daus # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…on-daus # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…on-daus # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…on-daus # Conflicts: # DuckDuckGo-iOS.xcodeproj/project.pbxproj # DuckDuckGo-iOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
graeme
approved these changes
Jan 29, 2025
…on-daus # Conflicts: # DuckDuckGo-iOS.xcodeproj/project.pbxproj # DuckDuckGo-iOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 1, 2025
…sion events (#1177) Task/Issue URL: https://app.asana.com/0/1201462886803403/1208980858161408/f iOS PR: duckduckgo/iOS#3851 macOS PR: duckduckgo/macos-browser#3763 What kind of version bump will this require?: Minor **Description**: Update AutofillPixelReporter to support shared app group UserDefaults in order to count fill events from the iOS credential provider extension towards Autofill DAUs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201462886803403/1208980858161408/f
Tech Design URL:
CC:
Description:
Update to include fill events from the iOS credential provider extension towards Autofill DAUs in AutofillPixelReporter
Steps to test this PR:
Background: Pixel
m.autofill.activeuser
should only fire if both a DDG search and an autofill fill event have occurred in the same day.main
AutofillCredentialProvider
(selecting Safari when prompted with which app to run)m.autofill.activeuser
does NOT fire (this is because the extension has run before the app has had a chance to migrate existing UserDefault data and the extension is blocked from performing the migration since it cannot access the data to be migrated)AutofillCredentialProvider
and attempt to fill again in Safarim.autofill.activeuser
should now fire, since the condition of a DDG search + an autofill event have been met.Definition of Done (Internal Only):
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template