Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebView state restoration privacy feature #3838

Merged
merged 16 commits into from
Jan 21, 2025
Merged

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Jan 21, 2025

Task/Issue URL: https://app.asana.com/0/1206226850447395/1209192796290067/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Override privacy config with enabled feature: https://www.jsonblob.com/api/1331231315500130304
  2. Relaunch the app
  3. Open a bunch of tabs and navigate deeper so navigation history is present
  4. See if state is persisted: use debug menu to see if cache files are stored.
  5. Restart the app and observe if state of tabs is restored properly (back/forward navigation is restored).

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 self-assigned this Jan 21, 2025
@dus7 dus7 changed the base branch from main to mariusz/persist-webview-state January 21, 2025 10:34
@duckduckgo duckduckgo deleted a comment from github-actions bot Jan 21, 2025
@dus7 dus7 requested a review from brindy January 21, 2025 12:04
@dus7 dus7 marked this pull request as ready for review January 21, 2025 12:04
Base automatically changed from mariusz/persist-webview-state to main January 21, 2025 13:12
dus7 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jan 21, 2025
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
-->

Please review the release process for BrowserServicesKit
[here](https://app.asana.com/0/1200194497630846/1200837094583426).

**Required**:

Task/Issue URL:
https://app.asana.com/0/1206226850447395/1209192796290067/f
iOS PR: duckduckgo/iOS#3838
macOS PR: duckduckgo/macos-browser#3752
What kind of version bump will this require?: Major

**Optional**:

Tech Design URL:
CC:

**Description**:

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

**Steps to test this PR**:
1. See steps for iOS: duckduckgo/iOS#3838

<!--
Before submitting a PR, please ensure you have tested the combinations
you expect the reviewer to test, then delete configurations you *know*
do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
-->

**OS Testing**:

* [ ] iOS 14
* [ ] iOS 15
* [ ] iOS 16
* [ ] macOS 10.15
* [ ] macOS 11
* [ ] macOS 12

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dus7 dus7 merged commit d78c436 into main Jan 21, 2025
13 checks passed
@dus7 dus7 deleted the mariusz/webview-restoration-ff branch January 21, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants