Replace deprecated tab preview renderer #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nderer. The former is deprecated, and is known to cause issues on iOS 17.
samsymons
requested review from
a team,
mallexxx and
Bunn
and removed request for
a team and
mallexxx
Bunn
approved these changes
May 3, 2024
samsymons
added a commit
that referenced
this pull request
May 6, 2024
* main: Enable field validation for Sync payloads (#2807) Fix up address bar spoofing tests to match new behaviours. (#2743) Release 7.118.0-4 (#2821) Settings: onAppear changed to onDisappear (#2817) (#2820) Manage Expired Subscription (#2764) Replace deprecated tab preview renderer (#2814) Release 7.118.0-3 (#2819) Update release notes. Settings: onAppear changed to onDisappear (#2817) Release 7.118.0-2 (#2815) Improve VPN underlying error detail (#2813) Break the Subscription module’s dependency on BSK (#2804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207228085347616/f
Tech Design URL:
CC:
Description:
This PR replaces usage of
UIGraphicsBeginImageContextWithOptionswithUIGraphicsImageRenderer.UIGraphicsBeginImageContextWithOptionswas deprecated in iOS 17, and is reported to be unstable. We're seeing crashes with it ourselves, and the assertion suggests migrating to the new API, so here we are.Steps to test this PR:
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template