[Release PR] Update VPN metadata reporter #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add underlying errors.
samsymons
commented
Apr 30, 2024
Comment on lines
-243
to
-261
| case .overslept: return "overslept" | ||
| case .noNetworkAvailable: return "noNetworkAvailable" | ||
| case .unrecoverableNetworkChange: return "unrecoverableNetworkChange" | ||
| case .configurationFailed: return "configurationFailed" | ||
| case .serverAddressResolutionFailed: return "serverAddressResolutionFailed" | ||
| case .serverNotResponding: return "serverNotResponding" | ||
| case .serverDead: return "serverDead" | ||
| case .authenticationFailed: return "authenticationFailed" | ||
| case .clientCertificateInvalid: return "clientCertificateInvalid" | ||
| case .clientCertificateNotYetValid: return "clientCertificateNotYetValid" | ||
| case .clientCertificateExpired: return "clientCertificateExpired" | ||
| case .pluginFailed: return "pluginFailed" | ||
| case .configurationNotFound: return "configurationNotFound" | ||
| case .pluginDisabled: return "pluginDisabled" | ||
| case .negotiationFailed: return "negotiationFailed" | ||
| case .serverDisconnected: return "serverDisconnected" | ||
| case .serverCertificateInvalid: return "serverCertificateInvalid" | ||
| case .serverCertificateNotYetValid: return "serverCertificateNotYetValid" | ||
| case .serverCertificateExpired: return "serverCertificateExpired" |
There was a problem hiding this comment.
I very rarely see these appear in the metadata, so I've simplified it a bit. The only consequence of this is that we'll have to look up the reason by code each time it happens, but I personally think that's fine. But, let me know if you'd rather I add some field like codeDescription which maps a code to its actual meaning where possible.
graeme
approved these changes
Apr 30, 2024
|
Since we're looking at a new internal release soon, I'll merge this. |
samsymons
added a commit
that referenced
this pull request
May 1, 2024
* main: Release 7.118.0-1 (#2812) [Release PR] Update VPN metadata reporter (#2808) fix address bar weirdness (#2810) Fix RMF button styling for "big_two_action" format (#2811) Existing experiment disabled, the new Settings experiment activated (#2801) Create Asana Subtask on PR requested (#2803) Remove ATB from default params (#2430) Fix Kingfisher deprecation warnings (#2799) VPN server failure detection recovery (#2779) Disable the feedback send button when there’s no text (#2800)
samsymons
added a commit
that referenced
this pull request
May 1, 2024
# By Sam Symons (3) and others # Via Chris Brind (1) and GitHub (1) * main: Release 7.118.0-1 (#2812) [Release PR] Update VPN metadata reporter (#2808) fix address bar weirdness (#2810) Fix RMF button styling for "big_two_action" format (#2811) Existing experiment disabled, the new Settings experiment activated (#2801) Create Asana Subtask on PR requested (#2803) Remove ATB from default params (#2430) Fix Kingfisher deprecation warnings (#2799) VPN server failure detection recovery (#2779) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207207179448754/f
Tech Design URL:
CC:
Description:
This PR updates the VPN metadata reporter to include the domain, code, and information about any underlying errors. It also includes the localized description.
Steps to test this PR:
startTunnelfunction, add the following code:Now just try to toggle the VPN, and you'll see it shut off immediately. After that, go to the VPN debug menu and check the metadata - you should see error info, and an underlying error.
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template