Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates BSK #2577

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Updates BSK #2577

merged 3 commits into from
Mar 12, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Mar 12, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206800069675113/f

macOS: duckduckgo/macos-browser#2369
BSK: duckduckgo/BrowserServicesKit#716

Description

Fixes the following:

  • Several users seem to be no longer rekeying in the latest releases.
  • Some users seem to have trouble connecting due to these rekeying issues.

Testing:

  1. Try connecting a few times and make sure it works.
  2. Try setting the rekeying interval to something short and make sure rekeying works.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 12, 2024
@diegoreymendez diegoreymendez marked this pull request as ready for review March 12, 2024 22:15
@diegoreymendez diegoreymendez removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 12, 2024
@diegoreymendez diegoreymendez self-assigned this Mar 12, 2024
diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Mar 12, 2024
## Required

Task/Issue URL: 

iOS PR: duckduckgo/iOS#2577
macOS PR: duckduckgo/macos-browser#2369
What kind of version bump will this require?: Patch

## Description

Fixes the following:
- Several users seem to be no longer rekeying in the latest releases.
- Some users seem to have trouble connecting due to these rekeying issues.
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Mar 12, 2024
Task/Issue URL:
https://app.asana.com/0/1199230911884351/1206800069675113/f

iOS: duckduckgo/iOS#2577
BSK: duckduckgo/BrowserServicesKit#716

## Description

Fixes the following:
- Several users seem to be no longer rekeying in the latest releases.
- Some users seem to have trouble connecting due to these rekeying
issues.
@diegoreymendez diegoreymendez merged commit f01fef3 into release/7.112.0 Mar 12, 2024
13 checks passed
@diegoreymendez diegoreymendez deleted the diego/rekeying-fix branch March 12, 2024 23:19
samsymons added a commit that referenced this pull request Mar 14, 2024
* main:
  rollback #URL macro (#2585)
  Release 7.112.0-2 (#2579)
  Updates BSK (#2577)
samsymons added a commit that referenced this pull request Mar 14, 2024
…-lottie-animation

* sam/vpn-ui-improvements:
  Fix unit tests.
  rollback #URL macro (#2585)
  Release 7.112.0-2 (#2579)
  Updates BSK (#2577)
samsymons added a commit that referenced this pull request Mar 14, 2024
…n-ui-improvements-3-combine-notification-settings

* sam/vpn-ui-improvements-2-lottie-animation:
  Fix unit tests.
  rollback #URL macro (#2585)
  Release 7.112.0-2 (#2579)
  Updates BSK (#2577)
samsymons added a commit that referenced this pull request Mar 14, 2024
…' into sam/vpn-ui-improvements-4-location-setting-change

# By Sam Symons (2) and others
# Via Sam Symons (4) and Diego Rey Mendez (1)
* sam/vpn-ui-improvements-3-combine-notification-settings:
  Fix unit tests.
  rollback #URL macro (#2585)
  Release 7.112.0-2 (#2579)
  Updates BSK (#2577)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Mar 18, 2024
* main: (31 commits)
  Use History in Suggestions on iOS (#2552)
  Update wireguard-apple to 1.1.3 (#2598)
  Updates BSK to include latest changes (#2604)
  Fix VPN feedback form description (#2606)
  Fixes the name of a pixel (#2575)
  22. Subscription- Cleanup and minor updates (#2596)
  Release 7.112.0-3 (#2602)
  update embedded file
  Bump autoconsent to 10.3.0 (#2601)
  Roll back CPM post-rollout cleanup (#2599)
  Stub objects for Bookmarks DB (#2593)
  Subscriptions - 21. Manage Billing options to third parties (#2574)
  17. Subscription Review Fixes (#2547)
  bump bsk to fix retain cycle (#2595)
  New log for SKAd 4 integration (#2594)
  NetP x Subscription Clean-up (#2565)
  Update BSK to include latest macOS changes (#2588)
  rollback #URL macro (#2585)
  Release 7.112.0-2 (#2579)
  Updates BSK (#2577)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants