Cleanup after rolling out autoconsent enabled by default #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove autoconsent onByDefault subfeature
amddg44
reviewed
Mar 6, 2024
|
|
||
| func testDefaultAutoconsentStateIsTrue_WhenInRollout() { | ||
| let appUserDefaults = AppUserDefaults(groupName: testGroupName) | ||
| appUserDefaults.featureFlagger = createFeatureFlagger(withSubfeatureEnabled: true) | ||
| XCTAssertTrue(appUserDefaults.autoconsentEnabled) | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure if it makes sense to keep this test testAutoconsentReadsUserStoredValue_RegardlessOfRolloutState?
There was a problem hiding this comment.
True! Removed in 959f8f7.
samsymons
added a commit
that referenced
this pull request
Mar 8, 2024
* main: Point to BSK hotfix (#2558) Prevent redeeming invite codes after the VPN test ends (#2559) Updates Kingfisher to 7.11.0 (#2545) Makes network path metadata description anonymous (#2544) Adds pixels to track main VPN funnels (#2543) Cleanup after rolling out autoconsent enabled by default (#2537) Add #URL macro (#2540) Handle expired entitlement in NetP (#2525) Remove isSubscriptionEnabled check when attempting to delete NetP token (#2548) Validate correct environment (#2546) Remove CGNAT range (#2524) Add preliminary support for subscription keychain sharing (#2538) fix opening tabs with transitional (#2542) Integrate confirm entitlements endpoint (#2541) Makes dbSaveBloomFilterError daily and count (#2526) 16. Subscription: Display "Activation in progress" message (#2535) Autofill support for deleting all passwords (#2497) Bump BrowserServicesKit (#2532) Release 7.111.0-0 (#2534) if dax dialogs are showing then dismiss (#2506)
samsymons
added a commit
that referenced
this pull request
Mar 8, 2024
…-lottie-animation * sam/vpn-ui-improvements: Point to BSK hotfix (#2558) Prevent redeeming invite codes after the VPN test ends (#2559) Updates Kingfisher to 7.11.0 (#2545) Makes network path metadata description anonymous (#2544) Adds pixels to track main VPN funnels (#2543) Cleanup after rolling out autoconsent enabled by default (#2537) Add #URL macro (#2540) Handle expired entitlement in NetP (#2525) Remove isSubscriptionEnabled check when attempting to delete NetP token (#2548) Validate correct environment (#2546) Remove CGNAT range (#2524) Add preliminary support for subscription keychain sharing (#2538) fix opening tabs with transitional (#2542) Integrate confirm entitlements endpoint (#2541) Makes dbSaveBloomFilterError daily and count (#2526) 16. Subscription: Display "Activation in progress" message (#2535) Autofill support for deleting all passwords (#2497) Bump BrowserServicesKit (#2532) Release 7.111.0-0 (#2534) if dax dialogs are showing then dismiss (#2506)
samsymons
added a commit
that referenced
this pull request
Mar 8, 2024
…n-ui-improvements-3-combine-notification-settings * sam/vpn-ui-improvements-2-lottie-animation: (22 commits) Point to BSK hotfix (#2558) Prevent redeeming invite codes after the VPN test ends (#2559) Updates Kingfisher to 7.11.0 (#2545) Makes network path metadata description anonymous (#2544) Adds pixels to track main VPN funnels (#2543) Cleanup after rolling out autoconsent enabled by default (#2537) Add #URL macro (#2540) Handle expired entitlement in NetP (#2525) Remove isSubscriptionEnabled check when attempting to delete NetP token (#2548) Add dark mode animation. Allow the animation intro to be skipped Validate correct environment (#2546) Remove CGNAT range (#2524) Add preliminary support for subscription keychain sharing (#2538) fix opening tabs with transitional (#2542) Integrate confirm entitlements endpoint (#2541) Makes dbSaveBloomFilterError daily and count (#2526) 16. Subscription: Display "Activation in progress" message (#2535) Autofill support for deleting all passwords (#2497) Bump BrowserServicesKit (#2532) ...
samsymons
added a commit
that referenced
this pull request
Mar 8, 2024
…' into sam/vpn-ui-improvements-4-location-setting-change # By Sam Symons (4) and others # Via Sam Symons (3) and others * sam/vpn-ui-improvements-3-combine-notification-settings: (22 commits) Point to BSK hotfix (#2558) Prevent redeeming invite codes after the VPN test ends (#2559) Updates Kingfisher to 7.11.0 (#2545) Makes network path metadata description anonymous (#2544) Adds pixels to track main VPN funnels (#2543) Cleanup after rolling out autoconsent enabled by default (#2537) Add #URL macro (#2540) Handle expired entitlement in NetP (#2525) Remove isSubscriptionEnabled check when attempting to delete NetP token (#2548) Add dark mode animation. Allow the animation intro to be skipped Validate correct environment (#2546) Remove CGNAT range (#2524) Add preliminary support for subscription keychain sharing (#2538) fix opening tabs with transitional (#2542) Integrate confirm entitlements endpoint (#2541) Makes dbSaveBloomFilterError daily and count (#2526) 16. Subscription: Display "Activation in progress" message (#2535) Autofill support for deleting all passwords (#2497) Bump BrowserServicesKit (#2532) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Mar 11, 2024
* main: (28 commits) Fix VPN view model memory leak (#2570) Bump submodules/privacy-reference-tests from `40ce868` to `a603ff9` (#2500) 18. Subscription Entitlements caching (#2556) Release 7.111.0-2 (#2563) Revert "Report Apple Ad attribution using pixel (#2510)" (#2562) Vanilla browser integration (#2550) Fix blank space after URL bar hides (#2549) Release 7.111.0-1 (#2561) Point to BSK hotfix (#2558) Prevent redeeming invite codes after the VPN test ends (#2559) Updates Kingfisher to 7.11.0 (#2545) Makes network path metadata description anonymous (#2544) Adds pixels to track main VPN funnels (#2543) Cleanup after rolling out autoconsent enabled by default (#2537) Add #URL macro (#2540) Handle expired entitlement in NetP (#2525) Remove isSubscriptionEnabled check when attempting to delete NetP token (#2548) Validate correct environment (#2546) Remove CGNAT range (#2524) Add preliminary support for subscription keychain sharing (#2538) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206264112133008/1206441936959052/f
Description:
Removes usage of rollout subfeature and make autoconsent enabled by default for all users.
Steps to test this PR:
—
Internal references:
Software Engineering Expectations
Technical Design Template