Report on toggle protections off #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side of the screen
6 tasks
jaceklyp
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 11, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1205734628204384/f iOS PR: duckduckgo/iOS#2536 macOS PR: https://github.com/duckduckgo/iOS/actions/runs/8233888547 What kind of version bump will this require?: Major Description: Send a simplified breakage report through Pixel when user disables protections on iOS and macOS as such volume information from the toggle can help us identify breakage beyond what we can learn from regular breakage reports. We aim to: Explicitly request permission for such report without directing the user toward a specific response. Be transparent by openly listing the exact information we intend to send. Steps to test this PR: See: https://app.asana.com/0/0/1206747477156794/f
samsymons
added a commit
that referenced
this pull request
Mar 13, 2024
* main: Subscriptions: 20 - Subscription Caching (#2569) Subscriptions: 19. Error handling and minor updates (#2567) Use History on iOS (#2539) Release 7.112.0-1 (#2573) Report on toggle protections off (#2536) Release 7.112.0-0 (#2572) Update autoconsent to v10.2.0 (#2554) update metadata (#2571) Subscription pro pixels (#2531) Update SwiftSoup and Kingfisher versions (#2566) Move vpnFirstEnabled and networkPathChange out of VPNSettings (#2560) Fix VPN view model memory leak (#2570) Bump submodules/privacy-reference-tests from `40ce868` to `a603ff9` (#2500) 18. Subscription Entitlements caching (#2556) Release 7.111.0-2 (#2563) Revert "Report Apple Ad attribution using pixel (#2510)" (#2562) Vanilla browser integration (#2550) Fix blank space after URL bar hides (#2549) Release 7.111.0-1 (#2561)
samsymons
added a commit
that referenced
this pull request
Mar 13, 2024
…-lottie-animation * sam/vpn-ui-improvements: Subscriptions: 20 - Subscription Caching (#2569) Subscriptions: 19. Error handling and minor updates (#2567) Use History on iOS (#2539) Release 7.112.0-1 (#2573) Report on toggle protections off (#2536) Release 7.112.0-0 (#2572) Update autoconsent to v10.2.0 (#2554) update metadata (#2571) Subscription pro pixels (#2531) Update SwiftSoup and Kingfisher versions (#2566) Move vpnFirstEnabled and networkPathChange out of VPNSettings (#2560) Fix VPN view model memory leak (#2570) Bump submodules/privacy-reference-tests from `40ce868` to `a603ff9` (#2500) 18. Subscription Entitlements caching (#2556) Release 7.111.0-2 (#2563) Revert "Report Apple Ad attribution using pixel (#2510)" (#2562) Vanilla browser integration (#2550) Fix blank space after URL bar hides (#2549) Release 7.111.0-1 (#2561)
samsymons
added a commit
that referenced
this pull request
Mar 13, 2024
…n-ui-improvements-3-combine-notification-settings * sam/vpn-ui-improvements-2-lottie-animation: Subscriptions: 20 - Subscription Caching (#2569) Subscriptions: 19. Error handling and minor updates (#2567) Use History on iOS (#2539) Release 7.112.0-1 (#2573) Report on toggle protections off (#2536) Release 7.112.0-0 (#2572) Update autoconsent to v10.2.0 (#2554) update metadata (#2571) Subscription pro pixels (#2531) Update SwiftSoup and Kingfisher versions (#2566) Move vpnFirstEnabled and networkPathChange out of VPNSettings (#2560) Fix VPN view model memory leak (#2570) Bump submodules/privacy-reference-tests from `40ce868` to `a603ff9` (#2500) 18. Subscription Entitlements caching (#2556) Release 7.111.0-2 (#2563) Revert "Report Apple Ad attribution using pixel (#2510)" (#2562) Vanilla browser integration (#2550) Fix blank space after URL bar hides (#2549) Release 7.111.0-1 (#2561)
samsymons
added a commit
that referenced
this pull request
Mar 13, 2024
…' into sam/vpn-ui-improvements-4-location-setting-change # By Mariusz Śpiewak (3) and others # Via Sam Symons (4) and others * sam/vpn-ui-improvements-3-combine-notification-settings: Subscriptions: 20 - Subscription Caching (#2569) Subscriptions: 19. Error handling and minor updates (#2567) Use History on iOS (#2539) Release 7.112.0-1 (#2573) Report on toggle protections off (#2536) Release 7.112.0-0 (#2572) Update autoconsent to v10.2.0 (#2554) update metadata (#2571) Subscription pro pixels (#2531) Update SwiftSoup and Kingfisher versions (#2566) Move vpnFirstEnabled and networkPathChange out of VPNSettings (#2560) Fix VPN view model memory leak (#2570) Bump submodules/privacy-reference-tests from `40ce868` to `a603ff9` (#2500) 18. Subscription Entitlements caching (#2556) Release 7.111.0-2 (#2563) Revert "Report Apple Ad attribution using pixel (#2510)" (#2562) Vanilla browser integration (#2550) Fix blank space after URL bar hides (#2549) Release 7.111.0-1 (#2561) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1205734628204384/f
Tech Design URL: please, see within main task
CC: @shakyShane
Description:
Send a simplified breakage report through Pixel when user disables protections on iOS and macOS as such volume information from the toggle can help us identify breakage beyond what we can learn from regular breakage reports.
We aim to:
Steps to test this PR:
See: https://app.asana.com/0/0/1206747477156794/f
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template