15. Subscriptions: Properly sign out users and cache state #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
|
For the described scenario it worked as expected. Though for the first time I left the app when subscription was active with the settings open. And returning to the app the settings didn't refresh. |
miasma13
approved these changes
Mar 1, 2024
afterxleep
removed
the
bot: not in app board
Yeap, adding notification subscribers in the next PR |
quanganhdo
pushed a commit
that referenced
this pull request
Mar 4, 2024
Task/Issue URL: https://app.asana.com/0/0/1206707680638927/f Description: If the subscription has become inactive, the user may still see the options in settings. This forces a signout in that case and caches the subscription state data properly.
quanganhdo
pushed a commit
that referenced
this pull request
Mar 4, 2024
Task/Issue URL: https://app.asana.com/0/0/1206707680638927/f Description: If the subscription has become inactive, the user may still see the options in settings. This forces a signout in that case and caches the subscription state data properly.
samsymons
added a commit
that referenced
this pull request
Mar 6, 2024
# By Daniel Bernal (3) and others # Via GitHub * main: fix opening tabs with transitional (#2542) Integrate confirm entitlements endpoint (#2541) Makes dbSaveBloomFilterError daily and count (#2526) 16. Subscription: Display "Activation in progress" message (#2535) Autofill support for deleting all passwords (#2497) Bump BrowserServicesKit (#2532) Release 7.111.0-0 (#2534) if dax dialogs are showing then dismiss (#2506) Remove local BSK reference (#2529) 15. Subscription sign-out notification observers and Design Feedback (#2528) Upgrade to Xcode 15.2 (#2517) Report Apple Ad attribution using pixel (#2510) 15. Subscriptions: Properly sign out users and cache state (#2520) Check entitlement periodically and while rekeying NetP (#2461) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206707680638927/f
Description:
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template