14. Implemented Error handlers for all subscription scenarios #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….pir # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Subscription/Views/NavigationBarModifier.swift
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/SettingsSubscriptionView.swift
…riptions/14.error-handling
# Conflicts: # DuckDuckGo/Subscription/UserScripts/SubscriptionPagesUseSubscriptionFeature.swift # DuckDuckGo/Subscription/ViewModel/SubscriptionEmailViewModel.swift # DuckDuckGo/Subscription/ViewModel/SubscriptionFlowViewModel.swift # DuckDuckGo/Subscription/ViewModel/SubscriptionRestoreViewModel.swift # DuckDuckGo/Subscription/Views/SubscriptionFlowView.swift # DuckDuckGo/en.lproj/Localizable.strings
github-actions
bot
added
the
bot: not in app board
afterxleep
changed the title
afterxleep
removed
the
bot: not in app board
DuckDuckGo/Subscription/UserScripts/SubscriptionPagesUseSubscriptionFeature.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/Subscription/UserScripts/SubscriptionPagesUseSubscriptionFeature.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/Subscription/UserScripts/SubscriptionPagesUseSubscriptionFeature.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/Subscription/UserScripts/SubscriptionPagesUseSubscriptionFeature.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/Subscription/UserScripts/SubscriptionPagesUseSubscriptionFeature.swift
Show resolved
Hide resolved
DuckDuckGo/Subscription/UserScripts/SubscriptionPagesUseSubscriptionFeature.swift
Show resolved
Hide resolved
federicocappelli
requested changes
Feb 29, 2024
federicocappelli
approved these changes
Feb 29, 2024
afterxleep
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 29, 2024
Task/Issue URL: https://app.asana.com/0/1204099484721401/1206707680638894/f What kind of version bump will this require?: Minor iOS PR: duckduckgo/iOS#2508
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
afterxleep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206707680638882/f
Description:
This adds different error handling 'handles' to attach pixels and events, and streamlines the overall error handling flow in the UI
Steps to test this PR:
Confirm the 'happy paths' work as expected..
For example: