Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove banner #2456

Merged
merged 1 commit into from
Feb 8, 2024
Merged

remove banner #2456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions LocalPackages/SyncUI/Sources/SyncUI/Resources/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,6 @@
/* Standard Buttons - Paste Button */
"paste.button" = "Paste";

/* Description of rollout banner */
"preferences.sync.rollout-banner.description" = "Sync & Backup is rolling out gradually and may not be available yet within DuckDuckGo on your other devices.";

/* Preparing To Sync Sheet - Description */
"preparing.to.sync.sheet.description" = "Your bookmarks and passwords are being prepared to sync. This should only take a moment.";

Expand Down
1 change: 0 additions & 1 deletion LocalPackages/SyncUI/Sources/SyncUI/Views/Internal/UserText.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public struct UserText {

// Sync Title
public static let syncTitle = NSLocalizedString("sync.title", bundle: Bundle.module, value: "Sync & Backup", comment: "Sync & Backup Title")
static let syncRollOutBannerDescription = NSLocalizedString("preferences.sync.rollout-banner.description", bundle: Bundle.module, value: "Sync & Backup is rolling out gradually and may not be available yet within DuckDuckGo on your other devices.", comment: "Description of rollout banner")

// Sync Set Up
// Sync With Another Device Card
Expand Down
1 change: 0 additions & 1 deletion LocalPackages/SyncUI/Sources/SyncUI/Views/SyncSettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public struct SyncSettingsView: View {
}
}
} else {
rolloutBanner()
List {
if model.isSyncEnabled {

Expand Down
18 changes: 0 additions & 18 deletions LocalPackages/SyncUI/Sources/SyncUI/Views/SyncSettingsViewExtension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,24 +316,6 @@ extension SyncSettingsView {
}
}

@ViewBuilder
func rolloutBanner() -> some View {
Section {
HStack(alignment: .top, spacing: 16) {
Image("Info-Color-16")
Text(UserText.syncRollOutBannerDescription)
.font(.system(size: 12))
.foregroundColor(.primary)
.multilineTextAlignment(.leading)
.fixedSize(horizontal: false, vertical: true)
}
}
.padding()
.background(RoundedRectangle(cornerRadius: 8).foregroundColor(Color("RolloutBannerBackground")))
.padding(.bottom, 10)
.padding(.horizontal, 14)
}

enum LimitedItemType {
case bookmarks
case credentials
Expand Down
Loading