Don't crash when AppRatingPromptEntity fetch errors #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
requested changes
Jan 29, 2024
Core/PixelEvent.swift
Outdated
| @@ -1015,6 +1017,7 @@ extension Pixel.Event { | |||
| // MARK: - Return user measurement | |||
| case .debugReturnUserAddATB: return "m_debug_return_user_add_atb" | |||
| case .debugReturnUserUpdateATB: return "m_debug_return_user_update_atb" | |||
| case .appRatingPromptFetchError: return "m_app_rating_prompt_fetch_error" | |||
DuckDuckGo/AppRatingPrompt.swift
Outdated
| do { | ||
| results = try context.fetch(fetchRequest) | ||
| } catch { | ||
| DailyPixel.fireDailyAndCount(pixel: .appRatingPromptFetchError, error: error) |
There was a problem hiding this comment.
Does it send atb and appVersion? It should not.
There was a problem hiding this comment.
Oh I missed this comment. ATB is a good point but thought we’d perhaps want to know when it’s fixed by using appVersion. It’s included in the privacy triage.
|
@graeme What about sending atb and appVersion parameters? |
samsymons
added a commit
that referenced
this pull request
Feb 4, 2024
* main: (41 commits) Update BSK with autofill 10.1.0 (#2414) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408) Add Autoconsent onByDefault subfeature (#2423) Metadata reverted https://app.asana.com/0/0/1206476969305202/1206481077004998/f metadata updated Release 7.107.0-0 (#2421) More script fixes (#2419) More release script fixes (#2418) Release/7.106.0-4 (#2417) Reenable toggle on disallowing vpn (#2404) (#2416) Don't crash when AppRatingPromptEntity fetch errors (#2388) Add error codes to site breakage reports (#2413) Don't set dryRun for alpha builds (#2412) Add VPN redemption retry event (#2409) Changes to hotfix process (#2406) Release/7.106.0-3 changes (#2411) Fix tab loading (#2410) Improve waitlist invite code checks (#2398) Reenable toggle on disallowing vpn (#2404) Bump BrowserServicesKit to 103.0.2 (#2393) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206441184793818/f
Description:
Removes a fatal error when we try to fetch the
AppRatingPromptEntityand it errors. We might want to add a Pixel here, but there’s a silent recovery from the case that the fetch yields no results, so maybe we’re fine to just do the same here?Steps to test this PR:
This is hard to reproduce and the fix doesn’t seem like it could go wrong. However perhaps someone could sanity check this for me in case there’s a reason we’d want to crash or at least make a bit more noise when this happens
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template