Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display different copy in alerts when a flag is enabled in a newer version #2374

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Jan 24, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1206310394453442/f

Description: Shows a different copy in alerts when a sync flag is enabled in a newer version and the user needs to update the app

Steps to test this PR:

  1. Check BSK PR

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

SabrinaTardio added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jan 25, 2024
…rsion (#633)

Task/Issue URL: https://app.asana.com/0/72649045549333/1206310394453442/f
iOS PR: duckduckgo/iOS#2374
macOS PR: duckduckgo/macos-browser#2114
What kind of version bump will this require?: Major/Minor/Patch

Description: Shows a different copy in alerts when a sync flag is enabled in a newer version and the user needs to update the app
@SabrinaTardio SabrinaTardio merged commit 5ee96fb into main Jan 25, 2024
10 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/sync-flag-min-version branch January 25, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants