generation: ensure password gen feature flag is respected #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally introduced as a commit squashed into 8b046b1 (Android: enable iframe support (#536), 2024-04-09), but was accidentally removed via 18dd599 (android: revert "Android: enable iframe support (#536)" (#582), 2024-06-20). Reintroduce that commit, to ensure the `password_generation` runtime config flag is again respected and prevent password prompts after a user clicks "Never save for site". (cherry picked from commit 4c16e52)
GioSensation
approved these changes
Jun 21, 2024
This was referenced Jun 21, 2024
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Jun 21, 2024
Task/Issue URL: https://app.asana.com/0/1207634174804391/1207634174804391 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.0.1 ## Description Updates Autofill to version [12.0.1](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.0.1). ### Autofill 12.0.1 release notes ## What's Changed * generation: ensure password gen feature flag is respected by @sjbarag in duckduckgo/duckduckgo-autofill#583 **Full Changelog**: duckduckgo/duckduckgo-autofill@12.0.0...12.0.1 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: sjbarag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/0/1207632297018372/f
Description
This was originally introduced as a commit squashed into 8b046b1 (Android: enable iframe support (#536), 2024-04-09), but was accidentally removed via 18dd599 (android: revert "Android: enable iframe support (#536)" (#582), 2024-06-20). Reintroduce that commit, to ensure the
password_generationruntime config flag is again respected and prevent password prompts after a user clicks "Never save for site".(cherry picked from commit 4c16e52)
Steps to test