Add more tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jdorweiler
commented
Apr 28, 2022
jdorweiler
commented
- Adding tests for more CMP rules #1 and More rules for DE sites #3
- Renamed some rules to make it clear that they're single sites and not CMPs
|
Tests for netflix.com, national-lottery.co.uk, steampowered.com, usercentrics, and vodafone.de fail for me. I've tested these manually through a vpn and the rules do work. |
The JS API calls return promises which are truthy. We should coerce these values to booleans with a double negation.
sammacbeth
approved these changes
Apr 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.