Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix borlabs tests. #43

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix borlabs tests. #43

merged 1 commit into from
Nov 18, 2022

Conversation

sammacbeth
Copy link
Collaborator

https://app.asana.com/0/1203268166580279/1203312927712136/f

  1. The borlabs test case was using reitschuster.de, which now uses Sourcepoint. I've moved that site to the Sourcepoint test cases.
  2. On sites using borlabs, the popup is not correctly dismissed anymore. I've updated the rule to correctly run the opt-out, and added a self-test.

@sammacbeth sammacbeth requested a review from adewes November 8, 2022 13:00
@sammacbeth sammacbeth added bug Something isn't working patch Increment the patch version when merged release Create a release when this pr is merged labels Nov 8, 2022
@adewes
Copy link
Member

adewes commented Nov 17, 2022

Hey @sammacbeth, sorry that this took so long. I ran the automated tests but they seem to fail for two sites


  Slow test file: [firefox] › ../playwright/runner.ts (45s)
  Slow test file: [webkit] › ../playwright/runner.ts (44s)
  Slow test file: [chrome] › ../playwright/runner.ts (43s)
  Consider splitting slow test files to speed up parallel execution

  6 failed
    [webkit] › ../playwright/runner.ts:50:5 › borlabs › www.experto.de/ .NA optOut  ================
    [webkit] › ../playwright/runner.ts:50:5 › borlabs › www.kesselheld.de/ .NA optOut  =============
    [firefox] › ../playwright/runner.ts:50:5 › borlabs › www.experto.de/ .NA optOut  ===============
    [firefox] › ../playwright/runner.ts:50:5 › borlabs › www.kesselheld.de/ .NA optOut  ============
    [chrome] › ../playwright/runner.ts:50:5 › borlabs › www.experto.de/ .NA optOut  ================
    [chrome] › ../playwright/runner.ts:50:5 › borlabs › www.kesselheld.de/ .NA optOut  =============
  4 skipped
  6 passed (47s)

I also tested manually with Firefox Developer Edition and the cookie dialogs on experto.de and kesselheld.de get detected but no opt-out happens.

Copy link
Member

@adewes adewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now!

@sammacbeth sammacbeth merged commit 1a2b981 into main Nov 18, 2022
@sammacbeth sammacbeth deleted the sam/fix-borlabs branch November 18, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants