Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top level navigation blocks #825

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix top level navigation blocks #825

merged 2 commits into from
May 20, 2024

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented May 17, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1177771139624306/1207278769338326/f
iOS PR: duckduckgo/iOS#2871
macOS PR: duckduckgo/macos-browser#2792
What kind of version bump will this require?: Major/Minor/Patch

Optional:

Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Visit https://privacy-test-pages.site/
  2. Open the devtools and paste the following code in:
let btn = document.createElement('button'); document.body.prepend(btn);
btn.innerText = 'click me'
btn.addEventListener('click', ev => { ev.preventDefault(); window.open('https://google-analytics.com/') })
  1. Click the created button.
  2. Expected: new window is opened on google-analytics.com (or popup blocker triggers).

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this May 17, 2024
@SlayterDev SlayterDev marked this pull request as ready for review May 17, 2024 15:11
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
That fixed the issue, thanks! but only after cleaning app dir, i.e. content rules recompilation, so we‘ll need a CBR revision bump for the change to take effect

@SlayterDev SlayterDev merged commit a49bbac into main May 20, 2024
7 checks passed
@SlayterDev SlayterDev deleted the brad/window-cbr-fix branch May 20, 2024 17:49
samsymons added a commit that referenced this pull request May 20, 2024
* main:
  Fix top level navigation blocks (#825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants