Handle expired entitlement in NetP #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanganhdo
force-pushed
the
anh/netp-handle-expired-entitlement
branch
3 times, most recently
from
a582de9 to
c2504ab
Compare
quanganhdo
force-pushed
the
anh/netp-handle-expired-entitlement
branch
from
c88f953 to
1ab1e29
Compare
# Conflicts: # Sources/Subscription/AccountManager.swift # Sources/Subscription/Flows/AppStore/AppStoreAccountManagementFlow.swift # Sources/Subscription/Flows/AppStore/AppStorePurchaseFlow.swift # Sources/Subscription/Flows/AppStore/AppStoreRestoreFlow.swift # Sources/Subscription/Flows/Stripe/StripePurchaseFlow.swift
samsymons
added a commit
that referenced
this pull request
Mar 8, 2024
* main: Changes to 114.1.0-1 hotfix branch (#706) Navigation: Improve same-document navigation handling (#702) Add pixels for our main VPN funnels (#698) Remove Autoconsent subfeature (#697) #URL macro (#657) Handle expired entitlement in NetP (#692) Remove isSubscriptionEnabled check when attempting to delete NetP token (#701) Remove CGNAT range. (#691) Subscription keychain sharing for access token (#690) Integrate confirm entitlements endpoint (#700) fix bundle name in breakByRaisingSigInt (#699) Adds support for deleting all logins (#672) Bump C-S-S to 5.2.0 (#695) Update xcode-version to 15.2. (#688) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206409081785857/f
iOS PR: duckduckgo/iOS#2525
macOS PR:duckduckgo/macos-browser#2331
What kind of version bump will this require?: Minor
Optional:
Tech Design URL:
CC:
Description:
This PR adds proper entitlement expiration handling and addresses some tech debts with VPNSettings.
Steps to test this PR:
See platform-specific PRs.
<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
OS Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template