Avoid sending latency immediately after the monitor starts #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the app would think it needs to send its very first latency measurement after starting up, which won’t necessarily be a good representation of the quality.
This was referenced Jan 22, 2024
diegoreymendez
approved these changes
Jan 22, 2024
samsymons
deleted the
sam/avoid-sending-first-latency-measurement-as-pixel
branch
samsymons
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jan 23, 2024
Task/Issue URL: https://app.asana.com/0/0/1206412872188595/f Tech Design URL: CC: @diegoreymendez Description: Client PR for duckduckgo/BrowserServicesKit#630
samsymons
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jan 23, 2024
Task/Issue URL: https://app.asana.com/0/0/1206412872188595/f Tech Design URL: CC: Description: Client PR for duckduckgo/BrowserServicesKit#630
samsymons
added a commit
that referenced
this pull request
Jan 24, 2024
Required: Task/Issue URL: https://app.asana.com/0/0/1206412872188595/f iOS PR: duckduckgo/iOS#2368 macOS PR: duckduckgo/macos-browser#2103 What kind of version bump will this require?: Patch Description: This PR fixes a bug in the latency monitor. See parent task for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1206412872188595/f
iOS PR: duckduckgo/iOS#2368
macOS PR: duckduckgo/macos-browser#2103
What kind of version bump will this require?: Patch
Description:
This PR fixes a bug in the latency monitor. See parent task for more info.
Steps to test this PR:
NetworkProtectionLatencyMonitorline 117 to print when the app is reporting latency backlet reportThreshold: TimeIntervalline to use 1 minute instead of 10 minutesIf you want to test this behaviour before, simply comment out line 95 and test again - you will see that the app is sending its very first measurement as a pixel, instead of collecting an average.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template