Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump autofill version #118

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Bump autofill version #118

merged 1 commit into from
Jul 15, 2022

Conversation

GioSensation
Copy link
Member

@GioSensation GioSensation commented Jul 14, 2022

Required:

Task/Issue URL: https://app.asana.com/0/1200194497630846/1202606879030948/f
iOS PR: duckduckgo/iOS#1238
macOS PR: duckduckgo/macos-browser#640
What kind of version bump will this require?: Minor

Description:
Bump autofill version. Minor fixes and improvements.

Steps to test this PR:

  1. Visit instagram.com and click on login and signup. The forms are correctly identified as a login form (you can autofill if you have credentials, otherwise nothing) and a signup form (offers to autofill the email).

OS Testing:

  • iOS 15
  • macOS 11

Internal references:

Software Engineering Expectations
Technical Design Template

Signed-off-by: Emanuele Feliziani <[email protected]>
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested this via the respective client PRs, a smoke test of autofill and following the specific instructions in this PR all worked as expected.

@GioSensation
Copy link
Member Author

Bitrise failiure is a false positive. Merging.

@GioSensation GioSensation merged commit e6e859f into main Jul 15, 2022
@GioSensation GioSensation deleted the ema/update-autofill branch July 15, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants