Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional "default browser" prompts: fixed an issue with disabling the experiment remotely #5616

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LukasPaczos
Copy link
Contributor

@LukasPaczos LukasPaczos commented Feb 7, 2025

Task/Issue URL: https://app.asana.com/0/1208671518894266/1209349005070380

Description

Checks whether there are valid evaluators for a cohort, or clean ups side effects if not. This helps with a situation when the experiment is disabled remotely and there's no current active cohort.

Steps to test this PR

  1. Open the app and go through onboarding. DDG should not be set as your default browser.
  2. Load this config https://www.jsonblob.com/api/1337370852936835072 which contains the experiment enabled for variant 3.
  3. Change the device's date to next day, a CTA dialog will show and a menu item will be added.
  4. Load this config https://www.jsonblob.com/api/1337385724919603200 which has the experiment disabled.
  5. The menu item should be gone.

Example video:

Screen_recording_20250207_124710.webm

@LukasPaczos LukasPaczos requested a review from malmstein February 7, 2025 11:53
@LukasPaczos LukasPaczos force-pushed the feature/lukasz-p/default-browser-prompts-disabling-remotely-fix branch from bb7bce7 to 3b25413 Compare February 7, 2025 12:10
Base automatically changed from feature/lukasz-p/default-browser-prompts-conversion-fix to develop February 7, 2025 13:22
@LukasPaczos LukasPaczos force-pushed the feature/lukasz-p/default-browser-prompts-disabling-remotely-fix branch from 3b25413 to a143577 Compare February 7, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant