Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offerId to purchase method in SubscriptionsManager #5532

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jan 24, 2025

Task/Issue URL: https://app.asana.com/0/1201807753394693/1209226459318682/f

Description

Include offerId argument in subscriptions purchase method

Steps to test this PR

Pre steps

  • Apply patch to being able to test subscriptions in staging

Privacy Pro Eligible US

  • Make sure you are US eligible
  • Install form branch
  • Go to Settings
  • Check you can see Privacy Pro option
  • Tap on that option
  • Check Subscriptions page looks as expected with full price subscriptions
  • Purchase any of the options
  • Check Free Trial is not offered when GooglePlay dialog for purchase is shown
  • Subscribe
  • Check everything works as expected

Privacy Pro Eligible ROW (Optional)

  • Make sure you are ROW eligible
  • Install form branch
  • Check browser works as expected
  • Go to Settings
  • Check you can see Privacy Pro option
  • Tap on that option
  • Check Subscription page looks as expected
  • Purchase any of the options and check it works well
  • Go to Subscription Settings
  • Check everything works as expected

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review January 24, 2025 12:54
Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected.

@@ -75,6 +75,7 @@ interface PlayBillingManager {
activity: Activity,
planId: String,
externalId: String,
offerId: String? = null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I doesn't seem like we need that default value here. Right now, SubscriptionManager is always passing a value for offerId. Without that default value it will be harder to miss that parameter e.g., when refactoring something in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants