Add navigatorInterface + messageBridge support #5461
Merged
+1,118
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
joshliebe
changed the title
joshliebe
force-pushed
the
feature/josh/navigator-interface
branch
from
ca11b5c to
f87ff09
Compare
10 tasks
joshliebe
force-pushed
the
feature/josh/navigator-interface
branch
from
f87ff09 to
63e7261
Compare
13 tasks
malmstein
approved these changes
Jan 24, 2025
...ava/com/duckduckgo/contentscopescripts/impl/features/messagebridge/di/MessageBridgeModule.kt
Show resolved
Hide resolved
...ava/com/duckduckgo/contentscopescripts/impl/features/messagebridge/store/MessageBridgeDao.kt
Show resolved
Hide resolved
|
|
||
| @Entity(tableName = "message_bridge") | ||
| data class MessageBridgeEntity( | ||
| @PrimaryKey val id: Int = 1, |
There was a problem hiding this comment.
discussed this offline, we don’t really seem to need a Room db, but since this pattern is already used in other c-s-s features let’s not change anything now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208697679300718/f
Description
content-scope-scripts-implmodule to inject thenavigatorInterfaceJSON from the privacy config.messageBridgeC-S-S feature which is required for SERP<->native communication.Steps to test this PR
navigatorInterface
messageBridge
chrome://inspectnavigator.duckduckgo.createMessageBridge(“aiChat").notify("helloWorld”)