Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixel for when automatic clear settings dialogs are shown #409

Merged

Conversation

CDRussell
Copy link
Member

Task/Issue URL: https://app.asana.com/0/193817002363848/948421103947412
Tech Design URL:
CC:

Description:
Adds pixels for when the what/when settings dialogs are shown

Steps to test this PR:

  1. Enable proxy
  2. Click on the "Automatically clear..." what option; verify the macwhat_s pixel is created
  3. Click on the "Clear on..." when option; verify the macwhen_s pixel is created

Internal references:

Software Engineering Expectations
Technical Design Template

@CDRussell CDRussell merged commit ead6e4b into develop Dec 17, 2018
@CDRussell CDRussell deleted the feature/pixels_on_automatical_clearing_dialog_shown branch December 17, 2018 11:39
nalcalag pushed a commit that referenced this pull request Apr 4, 2024
Task/Issue URL:
https://app.asana.com/0/1207001382250011/1207001382250011
Autoconsent Release:
https://github.com/duckduckgo/autoconsent/releases/tag/v10.5.0


## Description
Updates Autoconsent to version
[v10.5.0](https://github.com/duckduckgo/autoconsent/releases/tag/v10.5.0).

### Autoconsent v10.5.0 release notes
#### 🚀 Enhancement

- Fix Moove on mitglieder.franzspitzer.de
[#409](duckduckgo/autoconsent#409)
([@muodov](https://github.com/muodov))
- Add .cc-type-out-out variant of Complianz popup
[#402](duckduckgo/autoconsent#402)
([@sammacbeth](https://github.com/sammacbeth))
- Rules for two Ensighten banner variants
[#403](duckduckgo/autoconsent#403)
([@sammacbeth](https://github.com/sammacbeth))

#### Authors: 2

- Maxim Tsoy ([@muodov](https://github.com/muodov))
- Sam Macbeth ([@sammacbeth](https://github.com/sammacbeth))

## Steps to test
This release has been tested during Autoconsent development. You can
check the release notes for more information.

Co-authored-by: muodov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants