You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It'll also be extremely useful to return an array for shares deposited in depositCore.
This is because on autoswap the amount deposited is not actually the same as the amount credited to the depositor. Additionally, shares is what is used when withdrawing (not reserves).
Whether we have it in addition to amounts deposited or instead of, I have no opinion for.
The text was updated successfully, but these errors were encountered:
@eljhfx can you include this change as part of your PR? Sounds like we're already emitting the correct event so idk if you even need that return value.
It'll also be extremely useful to return an array for shares deposited in depositCore.
This is because on autoswap the amount deposited is not actually the same as the amount credited to the depositor. Additionally, shares is what is used when withdrawing (not reserves).
Whether we have it in addition to amounts deposited or instead of, I have no opinion for.
The text was updated successfully, but these errors were encountered: