Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return shares deposited in depositCore #237

Open
PossibilityResult opened this issue Dec 11, 2022 · 2 comments
Open

Return shares deposited in depositCore #237

PossibilityResult opened this issue Dec 11, 2022 · 2 comments

Comments

@PossibilityResult
Copy link
Contributor

It'll also be extremely useful to return an array for shares deposited in depositCore.

This is because on autoswap the amount deposited is not actually the same as the amount credited to the depositor. Additionally, shares is what is used when withdrawing (not reserves).

Whether we have it in addition to amounts deposited or instead of, I have no opinion for.

@finkbeca finkbeca reopened this Dec 11, 2022
@finkbeca
Copy link
Contributor

finkbeca commented Dec 11, 2022

We should be emitting this correctly within the emitted events, but not currently as a response. It should be easy to add this to a response.

@teddyknox
Copy link
Contributor

@eljhfx can you include this change as part of your PR? Sounds like we're already emitting the correct event so idk if you even need that return value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants