Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithdrawCore should return shares, and the amount A and amount B that (actually) ended up being deposited #107

Closed
PossibilityResult opened this issue Nov 17, 2022 · 4 comments
Closed

WithdrawCore should return shares, and the amount A and amount B that (actually) ended up being deposited #107

PossibilityResult opened this issue Nov 17, 2022 · 4 comments
Labels
quality of life
Milestone
v0.1.1

Comments

@PossibilityResult
Copy link
Contributor

No description provided.

@teddyknox
Copy link
Contributor

@eljhfx This is useful for inter-module communication but do we have that need right now? Asking because it will determine the priority of this issue.

@teddyknox teddyknox added the question Further information is requested label Nov 21, 2022
@PossibilityResult PossibilityResult added the optimization New feature or request label Nov 21, 2022
@PossibilityResult
Copy link
Contributor Author

Not necessary right now but will be useful in the future. At some point we should probably do a full sweep of all of the return values and brainstorm usecases though.

@teddyknox teddyknox added quality of life and removed optimization New feature or request question Further information is requested labels Nov 21, 2022
@teddyknox
Copy link
Contributor

Should also do this kind of analysis on other functions

@teddyknox teddyknox added this to the v0.1.1 milestone Nov 29, 2022
@jcompagni10
Copy link
Collaborator

unfixed bit is captured by #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality of life
Projects
None yet
Milestone
v0.1.1
Development

No branches or pull requests
3 participants
@teddyknox @jcompagni10 @PossibilityResult