Guarantee trivial copy constructor and destructor for Str and Slice #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the System V ABI to pass them in registers. See page 20 of https://software.intel.com/sites/default/files/article/402129/mpx-linux64-abi.pdf.
Repro:
Before:
After:
This change is also observable by
std::is_trivially_copy_constructible<rust::Str>()
(https://en.cppreference.com/w/cpp/types/is_copy_constructible) which lets us hit better fastpaths in libraries downstream.