Allow namespace override #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows a #[namespace (namespace = A::B)] attribute for each item in a cxx::bridge. We now have a fair number of different types of name floating around: * C++ identifiers * C++ fully-qualified names * Rust identifiers * Rust fully-qualified names (future, when we support sub-modules) * Items with both a Rust and C++ name (a 'Pair') * Types with only a known Rust name, which can be resolved to a C++ name. This change attempts to put some sensible names for all these things in syntax/mod.rs, and so that would be a good place to start review. At the moment, the Namespace (included in each CppName) is ruthlessly cloned all over the place. As a given namespace is likely to be applicable to many types and functions, it may save significant memory in future to use Rc<> here. But let's not optimise too early.
sbrocket
reviewed
Oct 29, 2020
|
Thanks for the review! I agree with all your points and will (eventually) get to them. |
sbrocket
reviewed
Oct 29, 2020
Closed
dtolnay
approved these changes
Oct 29, 2020
dtolnay
reviewed
Oct 29, 2020
dtolnay
reviewed
Oct 29, 2020
|
Thanks for merging! I will prioritize a PR to get the syntax finalized per #370 (comment) (I assume you agree with that @dtolnay ), hopefully I'll get that done tomorrow. I'll then do more cleanup PRs subsequently for all the other comments. Thanks for the review both! |
|
Yeah it should be |
This was referenced Oct 30, 2020
Merged
This was referenced Oct 31, 2020
This was referenced Nov 11, 2020
This was referenced Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of lots of commits adding tests, then a commit which actually achieves it.
It should achieve points 1-3 on the plan in #353, and most of #4 (it doesn't currently look for namespace attributes on
externblocks but the rest is done).Obsoletes #369.