Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with indirect return for C++ member function w/no args #210

Merged
merged 2 commits into from
May 22, 2020
Merged

Fix issue with indirect return for C++ member function w/no args #210

merged 2 commits into from
May 22, 2020

Conversation

myronahn
Copy link
Contributor

A FFI C++ member function (i.e. function w/receiver) with no args and an indirect return (i.e. one that returns a Result<T>) was generating a function signature with a missing comma between the self arg and the indirect return parameter.

The get_fail() test member function will trigger this error.

The one-liner fix is in gen/src/write.rs

@dtolnay dtolnay merged commit e3b78ea into dtolnay:master May 22, 2020
@dtolnay
Copy link
Owner

dtolnay commented May 22, 2020

Thanks, published in 0.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants