Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contributor's Guide for Adding Use Cases #818

Merged
merged 6 commits into from
Feb 24, 2021

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Feb 23, 2021

Updated instructions for adding a new use case to reflect new changes to GitHub Actions structure and added information that was previously missing

Pull Request Testing

  • Describe testing already performed for these changes:

    None, really. I just reviewed the changes to the process and added content to reflect the changes.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the new content to ensure it is clear and correct

  • Do these changes include sufficient documentation and testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

… to GitHub Actions structure and added information that was previously missing
@georgemccabe georgemccabe added this to the METplus-4.0.0 milestone Feb 23, 2021
@georgemccabe georgemccabe marked this pull request as ready for review February 23, 2021 01:40
Took out an extra comma.
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! They all seem clear to me, however, I am only familiar with some of these instructions. It's always a work in progress, and we can always continue to make improvements as others follow these instructions. I approve this pull request.

@georgemccabe georgemccabe merged commit a7b2dbe into develop Feb 24, 2021
@georgemccabe georgemccabe deleted the feature_update_contrib_guide branch February 24, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants