Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 794 change master_metplus to run_metplus #805

Merged
merged 5 commits into from
Feb 18, 2021

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Feb 16, 2021

changed all instances of master_metplus to run_metplus

Pull Request Testing

  • Describe testing already performed for these changes:

Ran a few use cases and verified they still ran properly
Verified that a warning message is output when running master_metplus.py

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Run some use cases using run_metplus.py and master_metplus.py and ensure that everything looks correct using either script
Run master_metplus.py and ensure warning message is sufficient

  • Do these changes include sufficient documentation and testing updates? [Yes]

Updated documentation to use run_metplus.py

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-4.0.0 milestone Feb 16, 2021
@georgemccabe georgemccabe linked an issue Feb 16, 2021 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the files changed. On kiowa in /d1/projects/METplus/METplus_pull_requests/METplus-4.0.0-beta4/feature_794, Iran two use cases:
*use_cases/met_tool_wrapper/GenVxMask/GenVxMask_multiple.py
*use_cases/met_tool_wrapper/ASCII2NC/ASCII2NC.conf
using run_metplus.py and master_metplus.py ensured that everything looks correct using either script.

When running master_metplus.py, I saw the warning message:
"02/17 14:46:53.060 metplus (master_metplus.py:50) WARNING: master_metplus.py has been renamed to run_metplus.py. This script name will be removed in a future version."
which seems sufficient.

I did notice that the version seems to be set to "4.0.0-rc1-dev":
"Running METplus 4.0.0-rc1-dev"
which was probably me setting that after the beta3 release before we knew there was going to be a beta4 release. I don't know that it should be fixed in this feature branch, but I at least wanted to mention it. Do you want me to fix that in the develop branch?

@georgemccabe georgemccabe merged commit f4f4b84 into develop Feb 18, 2021
@georgemccabe georgemccabe deleted the feature_794_run_metplus branch February 18, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename master_metplus.py to run_metplus.py
2 participants