Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_48_s2s_tdf_gdf #96

Merged
merged 10 commits into from
Mar 25, 2021
Merged

feature_48_s2s_tdf_gdf #96

merged 10 commits into from
Mar 25, 2021

Conversation

DanielAdriaansen
Copy link
Contributor

Pull Request Testing

Plotting script for the use case in dtcenter/METplus#630. Tested in local branch and feature branch for METplus on Kiowa.

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@DanielAdriaansen DanielAdriaansen added this to the METplotpy-1.0 milestone Mar 25, 2021
Copy link
Contributor

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retrieved this branch and built a conda environment with it to test Dan's use case that uses the files from the PR. I was able to get the use case to run successfully using this version. I approve of this PR. Here are the steps I took to create the test environment:

runas met_test
cd ~/METplotpy
git pull
git checkout feature_48_s2s_tdf_gdf
git pull
conda create --name metplotpy_feature_48 python=3.6
conda activate metplotpy_feature_48
pip3 install matplotlib scipy pingouin
pip3 install .
conda install cartopy
pip3 install netCDF4

@georgemccabe georgemccabe merged commit acb8572 into develop Mar 25, 2021
@georgemccabe georgemccabe deleted the feature_48_s2s_tdf_gdf branch March 25, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants