Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 3009 net cdf docs #3016

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Feature 3009 net cdf docs #3016

merged 5 commits into from
Nov 14, 2024

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Nov 14, 2024

  • Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    No

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes or No]

    No

Pull Request Testing

  • Describe testing already performed for these changes:

    Read through documentation and checked to be sure it built successfully

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Read through the section of updated documentation to check for any needed changes/fixes
    https://met.readthedocs.io/en/feature_3009_netcdf_docs/Users_Guide/data_io.html#requirements-for-cf-compliant-netcdf

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    N/A

  • Will this PR result in changes to the MET test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    No

  • Will this PR result in changes to existing METplus Use Cases? [Yes or No]

    If yes, create a new Update Truth METplus issue to describe them.
    No

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:
    No

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@CPKalb CPKalb requested a review from j-opatz November 14, 2024 17:39
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates to the documentation are meaningful and direct the user more clearly with respect to the behavior of rotated lat-lon grids.

@j-opatz j-opatz merged commit c41d8fb into develop Nov 14, 2024
3 checks passed
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.0.0 milestone Nov 14, 2024
@JohnHalleyGotway JohnHalleyGotway deleted the feature_3009_netCDF_docs branch December 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Update documentation about parsing grid information from CF-compliant NetCDF files
3 participants