Update main_v9.1-ref after #1640 #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS.
* Per #1562, check for bad data values before adding data to the PDF's for grid_diag. * Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing.
…to print out some additional log messages that may help in debugging the intermittent file list failure.
* Per #1572, delete the docs/version file as it is not needed here. * Per #1572, update the version number to 9.1.1. * Per #1572, list the met-9.1.1 release date as 20201119 for the docs. * Per #1572, add release notes for the met-9.1.1 verison. * Per #1572, add release notes for met-9.1.1 version. * Per #1572, let's try to release met-9.1.1 today 11/18.
Co-authored-by: Howard Soh <[email protected]>
…ded in the next bugfix release for met-9.1. (#1640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Please see PR Update develop-ref after #1639 #1642 which updated develop-ref after the climo_cdf bugfix.
PR Bugfix 1638 main_v9.1 climo_cdf #1640 fixed the bug in Fix bug in the computation of the climatological CDF value. #1638 in the main_v9.1 branch. As expected, that caused the main_v9.1 NB to fail because of differences in the computed RPSS values and CLIMO_CDF fields in the gridded NetCDF matched pairs:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None necessary.
Do these changes include sufficient documentation and testing updates? [Yes]
This PR documents the reason for changing the reference revision.
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
As expected and described above.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone