Update main_v9.1-ref after 1562 #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS.
* Per #1562, check for bad data values before adding data to the PDF's for grid_diag. * Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing.
…to print out some additional log messages that may help in debugging the intermittent file list failure.
jprestop
approved these changes
Nov 17, 2020
JohnHalleyGotway
changed the title
JohnHalleyGotway
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix #1562 and pull request #1563 changed a configuration file in unit_grid_diag.xml. This resulted in an expected change in the nightly build output to this file:
test_output/grid_diag/grid_diag_temperature.nc
Merging main_v9.1 into main_v9.1-ref to get past these expected differences.
This is the same change as PR #1565
Pull Request Testing
Describe testing already performed for these changes:
Reviewed updated output to confirm that it is as expected.
Recommend testing for the reviewer to perform, including the location of input datasets:
None needed.
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
As described above.
After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone
Does not apply.