Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from tagging releases as met-X.Y to using vX.Y instead. #1541

Closed
7 of 20 tasks
JohnHalleyGotway opened this issue Oct 27, 2020 · 3 comments · Fixed by #1543, #1542, #1544 or #1545
Closed
7 of 20 tasks

Switch from tagging releases as met-X.Y to using vX.Y instead. #1541

JohnHalleyGotway opened this issue Oct 27, 2020 · 3 comments · Fixed by #1543, #1542, #1544 or #1545
Assignees
Labels
component: build process Build process issue component: release engineering Release engineering issue reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NCAR National Center for Atmospheric Research type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Task

The existing MET build/release conventions are not consistent with the other METplus components. This task is to make the following changes to make it consistent:

  1. Update the DockerHub automated build rules from expecting tags with a "met-" prefix to simply a "v" prefix.
  2. Retag "met-9.1" as "v9.1" and "met-10.0_beta1" as "v10.0-beta1" and make sure DockerHub builds them correctly.
  3. Update and test the build script to ensure that a tag named "v9.1" results in a tarfile named "met-9.1.YYYYMMDD.tar.gz" and a top-level directory named "met-9.1". So the script needs to strip off the leading "v".
  4. Coordinate with METplus engineers to make sure that this doesn't break the TravisCI automated testing.

Time Estimate

4 hours.

Sub-Issues

Consider breaking the task down into sub-issues.
None required.

Relevant Deadlines

Prior to the met-10.0-beta2 release.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added component: build process Build process issue type: task An actionable item of work priority: high requestor: NCAR National Center for Atmospheric Research component: release engineering Release engineering issue labels Oct 27, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0 milestone Oct 27, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Oct 27, 2020
@JohnHalleyGotway
Copy link
Collaborator Author

JohnHalleyGotway commented Oct 27, 2020

I updated the DockerHub autobuild rules with:

  1. DockerHub latest is built from GitHub tag vX.Y
  2. DockerHub X.Y* is built from GitHub tag vX.Y* (includes vX.Y-betaN)
  3. DockerHub X.Y-latest is built from GitHub tag vX.Y or vX.Y.Z
    I left the corresponding "met-" rules in place. Need to remember to delete them once the switch is done.

I recreated all the old tags using:

 git tag v9.1 met-9.1
 git push -u origin v9.1

Then I updated all the releases on GitHub to switch the tag from "met-9.1" to "v9.1". And lastly, I deleted all the old tags:

 git tag -d met-9.1
 git tag -u origin :met-9.1

I tested recreating the tarfile by running:

scripts/met_checkout_and_build.sh tag v9.1

But that creates "met-v9.1.20201027.tar.gz" which contains a "met-v9.1" directory. I need to update that script to strip the "v" from the "v9.1" in both cases.

JohnHalleyGotway added a commit that referenced this issue Oct 28, 2020
…ss tags named vX.Y instead of met-X.Y. Also have checkout_and_build call met_build from the SAME directory.
JohnHalleyGotway added a commit that referenced this issue Oct 28, 2020
…ss tags named vX.Y instead of met-X.Y. Also have checkout_and_build call met_build from the SAME directory. (#1542)
@JohnHalleyGotway JohnHalleyGotway linked a pull request Oct 28, 2020 that will close this issue
@JohnHalleyGotway JohnHalleyGotway linked a pull request Oct 28, 2020 that will close this issue
8 tasks
@JohnHalleyGotway
Copy link
Collaborator Author

Merged changes into both the main_v9.1 and develop branches.

@JohnHalleyGotway
Copy link
Collaborator Author

Forgot to update the contents of the Dockerfile for this change.

This was linked to pull requests Nov 3, 2020
@TaraJensen TaraJensen added the reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build process Build process issue component: release engineering Release engineering issue reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NCAR National Center for Atmospheric Research type: task An actionable item of work
Projects
None yet
2 participants