Skip to content

Commit

Permalink
removed echo commands to group log output to allow script/job to fail…
Browse files Browse the repository at this point in the history
… if the docker commands fail. The scripts are now called in separate steps that generate their own log files so these groups are no longer needed anyway.
  • Loading branch information
georgemccabe committed Jan 19, 2022
1 parent e337b08 commit 303ab44
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/jobs/build_docker_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ DOCKERHUB_TAG=dtcenter/met:${branch_name}

DOCKERFILE_DIR=${GITHUB_WORKSPACE}/scripts/docker

echo "::group::Docker Build Command"
time_command docker build -t ${DOCKERHUB_TAG} \
--build-arg SOURCE_BRANCH=$branch_name \
$DOCKERFILE_DIR
echo "::endgroup::"
2 changes: 0 additions & 2 deletions .github/jobs/push_docker_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ fi

echo "$DOCKER_PASSWORD" | docker login --username "$DOCKER_USERNAME" --password-stdin

echo "::group::Docker Push Command"
time_command docker push ${DOCKERHUB_TAG}
echo "::endgroup::"

0 comments on commit 303ab44

Please sign in to comment.