Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy repo fields #2411

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Clean up legacy repo fields #2411

merged 1 commit into from
Mar 17, 2025

Conversation

jvstme
Copy link
Collaborator

@jvstme jvstme commented Mar 14, 2025

  • Drop the logic for building RemoteRepoCreds.clone_url on server. Was needed for pre-0.18.6 clients. RemoteRepoCreds.clone_url is now required in client requests.
  • Drop now-unused repo fields from client requests and API docs. Server will still accept (and ignore) these fields for compatibility with pre-0.19.0 clients that set them to empty values.

- Drop the logic for building
  `RemoteRepoCreds.clone_url` on server. Was
  needed for pre-0.18.6 clients.
  `RemoteRepoCreds.clone_url` is now required in
  client requests.
- Drop now-unused repo fields from client requests
  and API docs. Server will still accept (and
  ignore) these fields for compatibility with
  pre-0.19.0 clients that set them to empty
  values.
@jvstme jvstme requested a review from r4victor March 14, 2025 19:31
@jvstme jvstme merged commit b91524b into master Mar 17, 2025
24 checks passed
@jvstme jvstme deleted the repo_model_fields branch March 17, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants