Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support the cursor IDE #2412

Closed
peterschmidt85 opened this issue Mar 16, 2025 · 3 comments · Fixed by #2413
Closed

[Feature]: Support the cursor IDE #2412

peterschmidt85 opened this issue Mar 16, 2025 · 3 comments · Fixed by #2413
Labels

Comments

@peterschmidt85
Copy link
Contributor

Problem

Currently, only vscode is supported as an ide value in dev environments.

If we simply replace vscode:// with cursor:// in the URL, it will all work.

Notes:
Check if the pre-installation of the IDE (of the requested version) is done the same way as with code.

Solution

No response

Workaround

No response

Would you like to help us implement this feature by sending a PR?

Yes

@peterschmidt85
Copy link
Contributor Author

peterschmidt85 commented Mar 16, 2025

@jvstme Currently, we have a logic that pre-installs VSCode server along with a few extensions. I wonder if we really need it. Perhaps we could drop it altogether and simplify the process a lot. VSCode will automatically download the server on the first connection. Please let me know if this is OK.

And, also, we will drop the version field as it's not really needed. In the end, the remote version should match the local desktop IDE version. If it's automatically installed on first connection, it all will just work.

The simpler the logic, the easier it is to maintain.

@r4victor
Copy link
Collaborator

@peterschmidt85, But vscode won't install extensions that dstack currently installs automatically, so users would need to install them manually, e.g. ms-python.python. Definitely a downgrade in terms of UX without a clear benefit.

@peterschmidt85
Copy link
Contributor Author

@r4victor OK, for now, lets keep it all as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants