Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP-AV Extension: VS_ATTENUATION_CHARACTERISTICS, DSPACE_SCS_DIAG_IND #25

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

TGruett
Copy link
Contributor

@TGruett TGruett commented Jan 23, 2025

Added dissection for VS_ATTENUATION_CHARACTERISTICS and DSPACE_SCS_DIAG_IND HomePlug packets

@TGruett TGruett changed the title HP-AV Extension HP-AV Extension: VS_ATTENUATION_CHARACTERISTICS, DSPACE_SCS_DIAG_IND Jan 23, 2025
Copy link
Contributor

@adoebber adoebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor remarks

README.md Outdated
@@ -24,7 +24,7 @@ This Wireshark plugin allows to analyze and decode packets between electric vehi
- Validation of V2G messages according to XSD specification
- Certificate information details for Plug & Charge (PnC)
- Live TLS decryption <small>(requires secret disclosure)</small>
- LLC diagnostics via HomePlug AV packets for sniffer and debug packets
- SCS diagnostics via HomePlug AV packets for sniffer and debug packets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The abbreviation is not explained in the readme?

Wireshark/plugins/v2ghpscs.lua Outdated Show resolved Hide resolved
Wireshark/plugins/v2ghpscs.lua Outdated Show resolved Hide resolved
Wireshark/plugins/v2ghpscs.lua Outdated Show resolved Hide resolved
Wireshark/plugins/v2ghpscs.lua Outdated Show resolved Hide resolved
@TGruett TGruett merged commit 0914449 into main Jan 24, 2025
@TGruett TGruett deleted the feature/hpav_diagnostics branch January 24, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants