fix(rm): ignore NotFound errors when --force flag is set

[pkedy]

This PR adds a try/catch inside executeRemove and ignores NotFound errors when force is set.

This is inline with the behavior of rm -Rf on Unix.

[dsherret]

Thanks @pkedy! Would you be able to add a test to mod.test.ts for this under "test remove" to ensure we don't get a regression in the future?

[dsherret]

I believe it should just be a try/catch around this Deno.remove only so it doesn't exit if one of the paths fails?

Maybe just:

return Deno.remove(path, { recursive: flags.recursive }).catch(err => {
  if (flags.force && err instanceof Deno.errors.NotFound) {
    return Promise.resolve();
  } else {
    return Promise.reject(err);
  }
});

[pkedy]

I tried the try/catch around the Deno.remove and the exception still bubbled up. Your snippet with catch looks promising and worth a try though. I'll also see about adding a test.

Thanks for this project, BTW. I needed something like shx for Deno in our code generation project called Apex and this fits the bill!

[dsherret]

That project looks really useful.

[pkedy]

@dsherret I added the test. Pls approve the workflow to run. I'm expecting the test to fail on Windows because I don't know how the OS error from Deno.remove will be formatted. If that is the case, feel free to edit my branch to move this along. It would be great to get this in a release.

[dsherret]

I have a Windows machine. I'll fix it locally on Windows then push to the PR.

[dsherret]

LGTM. Thanks @pkedy! I will do a release later today.