fixing iterator bug

dsec-capital · Apr 14, 2024 · 12e1ecb · 12e1ecb
1 parent 63ed6d4
commit 12e1ecb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/fix_simulation_server/application.cpp b/fix_simulation_server/application.cpp
@@ -102,11 +102,14 @@ void Application::onLogout(const FIX::SessionID& sessionID)
 		"====> removing market data subscriptions for senderCompID = {} targetCompID = {}", 
 		senderCompID, targetCompID
 	);
-	for (; it != market_data_subscriptions.end(); ++it) {
+	while(it != market_data_subscriptions.end()) {
 		if (senderCompID == it->second.first && targetCompID == it->second.second) {
 			spdlog::info("removing subscription for symbol={}", it->first);
 			it = market_data_subscriptions.erase(it);
 		}
+		else {
+			++it;
+		}
 	} 
 }
 

diff --git a/zorro_fix_plugin/zorro_fix_plugin.cpp b/zorro_fix_plugin/zorro_fix_plugin.cpp
@@ -569,12 +569,12 @@ namespace zfix {
 		if (it != order_id_by_internal_order_id.end()) {
 			auto [oit, success] = order_tracker.get_open_order(it->second);
 
-			spdlog::debug("BrokerSell2: found open order={}", oit->second.to_string());
-			show(std::format("BrokerSell2: found open order={}", oit->second.to_string()));
-
 			if (success) {
 				auto& order = oit->second;
 
+				spdlog::debug("BrokerSell2: found open order={}", order.to_string());
+				show(std::format("BrokerSell2: found open order={}", order.to_string()));
+
 				if (order.ord_status == FIX::OrdStatus_FILLED) {
 					double close_price;
 					int close_fill;