-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xIisModule: Move localization strings to strings.psd1 #521
xIisModule: Move localization strings to strings.psd1 #521
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #521 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 17 17
Lines 2661 2661
=======================================
Hits 2432 2432
Misses 229 229
Continue to review full report at Codecov.
|
Please update this PR similar to #510. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Outek)
CHANGELOG.md, line 6 at r2 (raw file):
- Moved xIisModule localization strings to strings.psd1.
We should move this entry under a new - Changes to xIisModule entry
Please also update with the correct issue (see other entries for example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
- Changes to xIisModule entry - Moved xIisModule localization strings to strings.psd1 (issue dsccommunity#466).
Pull Request (PR) description
MSFT_xIisModule: Move localization strings to strings.psd1
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is