xClusterNetwork: Fix Role property never in desired state

[claudiospizzi]

Pull Request (PR) description
Convert the network role to the enum value if it returns a stirng, e.g. on WS2016.

This Pull Request (PR) fixes the following issues:
Fixes #175

Task list:

• Change details added to Unreleased section of CHANGELOG.md?
• Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
• Examples appropriately updated?
• New/changed code adheres to Style Guidelines?
• Unit and (optional) Integration tests created/updated where possible?

---

This change is 

[codecov-io]

Codecov Report

Merging #176 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #176   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         7      7           
  Lines       434    437    +3     
===================================
+ Hits        434    437    +3

[johlju]

Reviewed 1 of 3 files at r1.
Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

DSCResources/MSFT_xClusterNetwork/MSFT_xClusterNetwork.psm1, line 40 at r1 (raw file):

    {
        # Try to convert the role to it's enum value
        $role = [String] [Int32] $NetworkResource.Role

Please see issue #175 for a suggestion that does need to try-catch a conversion. Would that be a better solution?

---

Comments from Reviewable

[claudiospizzi]

Added new test for the WS2016 role property

---

Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion.

---

DSCResources/MSFT_xClusterNetwork/MSFT_xClusterNetwork.psm1, line 40 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Please see issue #175 for a suggestion that does need to try-catch a conversion. Would that be a better solution?

Done

---

Comments from Reviewable

[claudiospizzi]

Done

---

Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[johlju]

Thanks for fixing the tests, appreciate it! I thought about it, but forgot to comment on that! Just one more comment about the test. I hope it will be as easy as the new test you already did. After that I think this is ready to merge. 😄

---

Reviewed 2 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Tests/Unit/MSFT_xClusterNetwork.Tests.ps1, line 156 at r2 (raw file):

                }

                It 'Should return the the correct values for the cluster network' {

Could we add a similar test when the role is in desired state as well for the new code path?

---

Comments from Reviewable

[claudiospizzi]

Done

---

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[johlju]

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[claudiospizzi]

Thanks @johlju

[johlju]

@claudiospizzi no problem. Thanks for fixing this! 😄